Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add triple slash comments for new System.Drawing API added in 6.0 #57313

Merged
merged 2 commits into from
Aug 13, 2021

Conversation

safern
Copy link
Member

@safern safern commented Aug 12, 2021

Contributes to: #54865

@ghost
Copy link

ghost commented Aug 12, 2021

Tagging subscribers to this area: @safern, @tarekgh
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to: #54865

Author: safern
Assignees: -
Labels:

area-System.Drawing

Milestone: -

@@ -197,6 +197,9 @@ public enum KnownColor
MenuHighlight,

// "Web" colors, Part 2
/// <summary>
/// A system defined color representing the ARGB value <c>#663399</c>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the existing docs, most of these seem to just be "A system-defined color.". I don't have a strong opinion, but calling out what seems like a discrepancy (if I'm looking in the right place).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw that some contained the ARGB code, i.e: Purple. That's why I added it, but I don't have a strong opinion either.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge this PR as is and if you have a strong opinion I can submit a new PR to fix that.

@safern
Copy link
Member Author

safern commented Aug 13, 2021

Failures are unrelated.

@safern safern merged commit 7b0a27e into dotnet:main Aug 13, 2021
@safern safern deleted the RebeccaPurpleDocs branch August 13, 2021 01:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants